Remove default props in AutoFocusInside to fix react 18 warning

theKashey / react-focus-lock

It is a trap! A lock for a Focus. 🔓

MIT License

1.27k stars 67 forks source link

Remove default props in AutoFocusInside to fix react 18 warning #238

Closed alex-e-leon closed 1 year ago

alex-e-leon commented 1 year ago

Fixes a warning with react 18. See this issue. https://github.com/theKashey/react-focus-lock/issues/239

alex-e-leon commented 1 year ago

Looks like there's a lint issue about an increase in package size. Considering the nature of my changes, I'm not sure how my changes affected the package size. Maybe it's an existing issue?

I'll leave it to you to look into.

theKashey commented 1 year ago

I should have migrated FocusLock to typescript years ago and stop using old React and language patterns as well.

Thank you for this contribution and don't worry about bundle size. size-limit is also VERY outdated