Unclear behavior during loosing focus in unmanaged area

theKashey / react-focus-lock

It is a trap! A lock for a Focus. 🔓

MIT License

1.25k stars 65 forks source link

Unclear behavior during loosing focus in unmanaged area #274

Closed theKashey closed 5 months ago

theKashey commented 7 months ago

Situation

There is uncontrolled modal opening from a focus-lock managed modal
New modal captures focus by
- 1) being to active and triggering focus-fighting surrender
- 2) or by being explicitly ignored (data-no-focus-lock)
focus will move to the new modal
...
uncontrolled modal is being closed
focus moves to the body
[ ] focus should be returned back to the controlled modal.
- this is unknown

Assumptions:

make controllable focusable
activate sticky focus
done

if focus was in the uncontrolled modal
and now is on body
and there is uncontrolled modal anymore
return focus

theKashey commented 7 months ago

Similar behavior was implemented for iframes https://github.com/theKashey/react-focus-lock/blob/master/src/Trap.js#L101

stale[bot] commented 5 months ago

This issue has been marked as "stale" because there has been no activity for 2 months. If you have any new information or would like to continue the discussion, please feel free to do so. If this issue got buried among other tasks, maybe this message will reignite the conversation. Otherwise, this issue will be closed in 7 days. Thank you for your contributions so far.

theKashey commented 5 months ago

When uncontrolled modal closed it will

or return focus where it belongs - there is no need to handle this case
or move it to the body
- in this case focus-lock will move focus where needed on any other node focus.

There is no way to act when focus moves to the body as this is default behavior for text selection.