search

theKashey / react-focus-on

🎯 Solution for WAI ARIA compatible modal dialogs or full-screen tasks, you were looking for
MIT License
342 stars 16 forks source link

removeScrollBar not exposed from react-remove-scroll #18

Closed AndrewBrough closed 1 year ago

AndrewBrough commented 5 years ago

I'd love to be able to remove the scroll bar but can't seem to access this prop. Would be nice to have it available!

Awesome package, does basically everything I need aside from this.

AndrewBrough commented 5 years ago

I can say the same about gapMode - I'd actually like to not have a gap, but it's enabled by default.

theKashey commented 5 years ago

I would recommend to import react-remove-scroll directly for now - reexporting it thought FocusLock might harm tree shaking (for the double imports case, aka sidecar, to be more concrete).

And gap have to be "reserved", or content on the page would jump, both changing width and height (as long as more "wider" text would consume less vertical space).

If you need something to be "100%" width - there are extra classNames exposed from remove-scroll to control this moment.

stale[bot] commented 1 year ago

This issue has been marked as "stale" because there has been no activity for 2 months. If you have any new information or would like to continue the discussion, please feel free to do so. If this issue got buried among other tasks, maybe this message will reignite the conversation. Otherwise, this issue will be closed in 7 days. Thank you for your contributions so far.