search

theKashey / react-focus-on

🎯 Solution for WAI ARIA compatible modal dialogs or full-screen tasks, you were looking for
MIT License
333 stars 14 forks source link

Missing Prop `noFocusGuards` #68

Closed RaidenDilan closed 1 year ago

RaidenDilan commented 1 year ago

Hi, I'm using this library and so far it's been working great but unfortunately I need noFocusGuards prop which is currently not exposed.

Happy to open a pull request, but I wanted to ask your preference:

Allow noFocusGuards prop only.

theKashey commented 1 year ago

Your contribution will be very appreciated 🙏, especially if you can share your example requiring this very rarely required prop.

RaidenDilan commented 1 year ago

So my usage is quite simple, I'd like to keep my HTML clean and semantic which is why I need to set noFocusGuards on. That way it would not be required for me to change any existing styling in my app to count for the extra divs. And I'm aware that the extra guards are there for virtual inputs which secure tab index.

RaidenDilan commented 1 year ago

Do you have any special requirements as to how you want pull requests to be opened or do I just create a branch from master and just open the pull request?

RaidenDilan commented 1 year ago

P.S. When I try to push my branch to remote repo, I get ERROR: Permission to theKashey/react-focus-on.git denied to RaidenDilan. Perhaps I need access to your repo.

theKashey commented 1 year ago

You are expected to Fork the repo and commit change to your version. Then you can open PR from your version to the upstream.

This way GitHub and the community can be assured that no unexpected change will ever be committed to the main branch, and branch protection rules were added years after this practice got established.

stale[bot] commented 1 year ago

This issue has been marked as "stale" because there has been no activity for 2 months. If you have any new information or would like to continue the discussion, please feel free to do so. If this issue got buried among other tasks, maybe this message will reignite the conversation. Otherwise, this issue will be closed in 7 days. Thank you for your contributions so far.