search

theKashey / react-focus-on

🎯 Solution for WAI ARIA compatible modal dialogs or full-screen tasks, you were looking for
MIT License
333 stars 14 forks source link

Adding support for `react-focus-lock` `crossFrame` prop #72

Closed cee-chen closed 1 year ago

cee-chen commented 1 year ago

Hey again @theKashey! 👋 We just got a question about iframe behavior from one of our consumers. While I was looking for a solution or workaround, I noticed that react-focus-lock supports a crossFrame prop that was added a few years ago (https://github.com/theKashey/react-focus-lock/issues/104) and would likely be exactly what we need.

Is there any chance we could extend FocusOn to allow the same crossFrame configuration and pass that to FocusLock? 🙏 That would be incredibly helpful to us. Would you accept a PR with this addition?

cee-chen commented 1 year ago

Thanks again for looking at this so quickly @theKashey! I know you're busy, but any chance you could drop a quick mention in this thread once the new feature has been released to npm? 🙏

theKashey commented 1 year ago

Better late than never 😅 3.9.0 has been released.