search

theKashey / react-focus-on

🎯 Solution for WAI ARIA compatible modal dialogs or full-screen tasks, you were looking for
MIT License
336 stars 14 forks source link

Warnings after upgrading to v3.0.0 #8

Closed smashercosmo closed 5 years ago

smashercosmo commented 5 years ago

Started getting the following warnings after upgrading:

Warning: Unknown event handler property `onActivation`. It will be ignored.
Warning: Unknown event handler property `onDeactivation`. It will be ignored.
theKashey commented 5 years ago

Thank you for reporting this issue. I've found a little time bomb with hooks and will release a new version tomorrow.

The real problem behind this issue - aria-hidden is not being set, while scroll-lock and focus-lock are working as they would. All units are working perfectly, but the integration part failed :(

smashercosmo commented 5 years ago

Thank you. Waiting for the new release then)

theKashey commented 5 years ago

Done. This time I've got a test for it :)