theKashey / react-focus-on

🎯 Solution for WAI ARIA compatible modal dialogs or full-screen tasks, you were looking for
MIT License
333 stars 14 forks source link

Prevent focus removal for external resources #80

Closed aronlg closed 3 months ago

aronlg commented 8 months ago

Hi,

How can I prevent pointer-events: none being applied to external resources(non React elements)?

Example: I have a sticky chat button loaded via Google tag manager. It renders outside root. Is there a way to apply it to shards somehow? or even better, prevent adding pointer-events: none to anything outside #root when <FocusOn> is enabled?

theKashey commented 8 months ago

Probably the best solution is to extend shouldIgnore to aria-hidden, the one applying pointer-events:none Simultaneously make focus-lock ignore aria-hidden elements.

That would be a good continuation of a joint efforts of different pieces this solution is composed from.

stale[bot] commented 6 months ago

This issue has been marked as "stale" because there has been no activity for 2 months. If you have any new information or would like to continue the discussion, please feel free to do so. If this issue got buried among other tasks, maybe this message will reignite the conversation. Otherwise, this issue will be closed in 7 days. Thank you for your contributions so far.

stale[bot] commented 4 months ago

This issue has been marked as "stale" because there has been no activity for 2 months. If you have any new information or would like to continue the discussion, please feel free to do so. If this issue got buried among other tasks, maybe this message will reignite the conversation. Otherwise, this issue will be closed in 7 days. Thank you for your contributions so far.