Replace detect-node with manual detection

theKashey / use-sidecar

Another way to code splitting

MIT License

104 stars 9 forks source link

Replace detect-node with manual detection #4

Closed TrySound closed 4 years ago

TrySound commented 4 years ago

detect-node does not support esm. In this diff I replaced it with detection via browser field. This way a lot of package use instead of checking globals.

See here https://github.com/visgl/react-map-gl/blob/master/package.json#L17-L25

theKashey commented 4 years ago

What about using detect-node-es ?

TrySound commented 4 years ago

I don't mind if you want to use it.

theKashey commented 4 years ago

Perfect 👍