search

theKashey / use-sidecar

Another way to code splitting
MIT License
104 stars 9 forks source link

update react version range #6

Closed just-boris closed 3 years ago

just-boris commented 3 years ago

The library does seem to work fine in React 17 (as long as I could test in our app).

Changing the version declaration is required to for compatibility with npm v7 behavior

Sadly, it does not print the warnings for all packages, so I needed to wait for https://github.com/theKashey/react-clientside-effect/pull/3 to be released, to then find a few more missing declarations.

Let's see if the current batch (this PR and https://github.com/theKashey/use-callback-ref/pull/12) will be enough to make it work

theKashey commented 3 years ago

should print all the warnings during installation. Definitely complains when using yarn.

PS: npm 7 would break everything 😭

theKashey commented 3 years ago

released use-sidecar@1.0.4

just-boris commented 3 years ago

The installation now works without --legacy-peer-deps. Thank you for the quick response!