search

theKashey / used-styles

📝All the critical styles you've used to render a page.
MIT License
138 stars 10 forks source link

fix: readme - lookup usage #19

Closed hnrchrdl closed 4 years ago

hnrchrdl commented 4 years ago

i ran into some confusion because of some inaccuracies in the readme's example code, so i created this PR to avoid others from having to run into the same.

thanks for this awesome library.

theKashey commented 4 years ago

Quite similar to https://github.com/theKashey/used-styles/pull/16.

Thank you for fixing up readme. How I hope those .md would be type-checkable.

hnrchrdl commented 4 years ago

Quite similar to #16.

i think you mean https://github.com/theKashey/used-styles/issues/18, which could also be closed now i guess.

theKashey commented 4 years ago

16 :) It just changed the way API should be consumed to make it simpler and easier to understand, as long it is not quite.

After you've updated readme the current version is also seems to be not that bad as before.