bug: nested style injection #53

theKashey / used-styles

📝All the critical styles you've used to render a page.

MIT License

137 stars 9 forks source link

Closed hnrchrdl closed 9 months ago

hnrchrdl commented 9 months ago

adds a failing test case #53

theKashey commented 9 months ago

👍👍👍👍 Failing test is a first step towards a proper fix

hnrchrdl commented 9 months ago

provided a potential fix, here is the logic i implemented:

when the last tag from the chunk is opening a style tag, means we are currently inside a style tag, so we inject right before that.
when the first tag from the chunk is closing a style tag, means we are currently inside a style tag, so we inject right after that.

let me know what you think.

theKashey commented 9 months ago

2.6.2 just released 🚀

hnrchrdl commented 9 months ago

2.6.2 just released 🚀

thanks!