theKashey / used-styles

📝All the critical styles you've used to render a page.
MIT License
137 stars 9 forks source link

ignore media rules nested to unknown at rules #65

Closed shlensky closed 4 months ago

shlensky commented 4 months ago

Current behaviour:

    const styles: StyleDefinition = loadStyleDefinitions(
      () => ['test.css'],
      () => `
@supports (display:grid) {
  .a { display: grid; }

  @media only print {
    .a { color: red; }
  }
}
`
    );
    await styles;

    const extracted = getCriticalRules('<div class="a">', styles);
    extracted === `
/* test.css */
@supports (display:grid) {
  .a { display: grid; }

  @media only print {
    .a { color: red; }
  }
}

/* test.css */
@media only print {
  .a { color: red; }
}`

It pulls @media rule outside of @supports, which is wrong.

theKashey commented 3 months ago

used-styles@2.6.5 has been released