Settlement storage is using v1.6 assets regardless of settlement version

theLaborInVain / kdm-manager-api

The API used by https://kdm-manager.com and related Kingdom Death: Monster utilities.

Other

3 stars 0 forks source link

Settlement storage is using v1.6 assets regardless of settlement version #56

Closed toconnell closed 2 years ago

toconnell commented 2 years ago

Likely because we're using the deprecated list_assets() method to create it.

toconnell commented 2 years ago

Actually, upon investigation, it looks like it's because the Storage model is initializing Assets objects without version. This is a little stickier...

toconnell commented 2 years ago

Ok, this ultimately boiled down to a really bad convenience/laziness method in the Storage module. Fixing it exposed...some skeletons in the closet of efficiency, however, as it has us initializing all gear/resource assets every time it looks up a single handle....

Anyway, this is fixed in the next release.