theMK2k / MetropolisLauncher

A data-heavy Emulation & Gaming front-end for Windows
http://metropolis-launcher.net
Other
40 stars 3 forks source link

DOSbox ECE Fluidsynth patch issue #25

Closed jxhicks closed 6 years ago

jxhicks commented 7 years ago

There appears to be a problem with the Fluidsynth gain setting for DOSbox ECE. It seems that when using the default setting of 0.600 it somehow gets reset to a null value in the .conf file resulting in no audible sound from MIDI in games. Setting it to something else, like 0.610 results it it working as expected. I do not have this problem with DOSbox ECE on it's own.

theMK2k commented 6 years ago

Bug confirmed.

Default values result in the following .conf entries:

fluid.samplerate=48000 fluid.gain= fluid.polyphony=256 fluid.cores=default fluid.periods=8 fluid.periodsize=512 fluid.reverb=yes fluid.reverb,roomsize= fluid.reverb.damping= fluid.reverb.width= fluid.reverb.level= fluid.chorus=yes fluid.chorus.number=3 fluid.chorus.level= fluid.chorus.speed= fluid.chorus.depth= fluid.chorus.type=0

this is not intended and will be fixed.

jxhicks commented 6 years ago

Oh wow, I didn't even notice all the other settings being left blank too. Thanks for looking into it.

theMK2k commented 6 years ago

Found the culprit, output is now:

fluid.samplerate=48000 fluid.gain=.6 fluid.polyphony=256 fluid.cores=default fluid.periods=8 fluid.periodsize=512 fluid.reverb=yes fluid.reverb,roomsize=.61 fluid.reverb.damping=.23 fluid.reverb.width=.76 fluid.reverb.level=.57 fluid.chorus=yes fluid.chorus.number=3 fluid.chorus.level=1.2 fluid.chorus.speed=.3 fluid.chorus.depth=8 fluid.chorus.type=0

which looks way better :)

jxhicks commented 6 years ago

That's great, thanks so much.

theMK2k commented 6 years ago

The bug should be fixed, please download the attached update and test :)

Metropolis_Launcher_1.1.1b_fluidsynth.zip

jxhicks commented 6 years ago

Just tested it and it looks to be working properly now. Thanks again.