theMK2k / MetropolisLauncher

A data-heavy Emulation & Gaming front-end for Windows
http://metropolis-launcher.net
Other
40 stars 3 forks source link

MobyGames link detection ineffective for MAME ROMs #34

Closed aaronjsolomon closed 6 years ago

aaronjsolomon commented 6 years ago

How can I efficiently link MAME games to their Moby data?

Moby releases appear on the right side of the ROM Browser, as expected.

At this point, I can select any/all of my MAME ROMs, right-click, and select "Detect MobyGames Links". However, since the basis of comparison is the ROM name and not the friendly game name, the matching algorithm predictably fails to find hardly any matches. It is effectively trying to match "nbbatman" to "Ninja Baseball Bat Man", and that obviously won't work, except in a handful of cases of games with a short, single word name. In my case, matches were found for 337 out of 13364 games. For the remainder of imported MAME ROMs, the match guesses were completely off.

Is there a way to use the MAME friendly game name, and not the ROM file name, as a basis for comparison during MobyGames link detection? The friendly game name is already available and showing in the "Games & Emulations" view, it's just not available in the ROM Browser, where link detection is actually performed. If the friendly name were the basis of comparison during link detection, it would work as well as any other platform.

Or, am I missing something obvious? Although I've read the help file, I'm not 100% confident that I'm approaching MAME game data handling correctly.

Please advise.

theMK2k commented 6 years ago

I can't recommend using mobygames meta data with arcade games yet because the quality of it is questionable. A much better meta data source are:

That's why you don't see any game being automatically linked to mobygames meta data in the ROM Manager.

I'll have a look into the link detection for the MAME Arcade platform and get back to you.

aaronjsolomon commented 6 years ago

I haven’t actually used these supplementary dat files with MAME before, and am not familiar with them. I’ll spend some more time getting familiar with their benefits. I love that ML guides the user into leveraging these various DAT file formats. There’s obviously a ton of great work in the MAME scene compiling data in interesting ways, but it’s usually far from obvious how to incorporate that into your actual setup.

As I see it, here are the benefits of allowing users to link MAME games to Moby (assuming I’m not missing something obvious):

My holy grail system has the following features:

  1. An easy way to see lists of related games (by series, developer, franchise, whatever), with all platforms represented and with all entries launchable. Basically, a way to imaginatively explore video game history, including franchises and companies, by pivoting through complete and consistent data sets.
  2. At least one decent image for each game, either box art or a title screen, to provide visual interest while browsing.
  3. Minimal quasi-duplicative game entries, where two games are really just versions of a single game. For instance, I’d like HD remasters to appear as sub-releases of the original game, and not a whole different game. I’d ESPECIALLY like to consolidate releases into a single game where one game has been given different names in different regions. For example, the game “1943” is varying called (depending on region and platform) “1943: The Battle of Midway”, “1943: The Battle of Valhalla”, “1943: Midway Kaisen”, etc. I’m trying to figure out a way to leverage the data so these all reliably end up under a single game listing, or at least a consistent, single game name, because they are in fact the same game, and the naming variants are only marketing anomalies.

2 seems especially well-served by the MobyGames notion of “groups”.

Please keep me posted on your decision whether to incorporate friendly game names for MAME ROMs into the comparison logic for MobyGames link detection.

On the other hand, if it’s just a matter of swapping out a couple of object attributes in the source code that feeds the ROM Browser, I might be able to make the code change myself. If you’d think it’s that simple of a fix, and you’d like to encourage contributor edits to source, let me know and I’ll spend some time getting Visual Studio fired up, learning github procedures, etc.

Thanks!

From: MK2k notifications@github.com Sent: Sunday, April 22, 2018 4:20 AM To: theMK2k/MetropolisLauncher MetropolisLauncher@noreply.github.com Cc: aaronjsolomon aaronjsolomon@gmail.com; Author author@noreply.github.com Subject: Re: [theMK2k/MetropolisLauncher] MobyGames link detection ineffective for MAME ROMs (#34)

I can't recommend using mobygames meta data with arcade games yet because the quality of it is questionable. A much better meta data source are:

That's why you don't see any game being automatically linked to mobygames meta data in the ROM Manager.

I'll have a look into the link detection for the MAME Arcade platform and get back to you.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/theMK2k/MetropolisLauncher/issues/34#issuecomment-383367353 , or mute the thread https://github.com/notifications/unsubscribe-auth/AkwiSBFFgAFja6_acphF3in2iwTD969Uks5trEskgaJpZM4Teuw9 . https://github.com/notifications/beacon/AkwiSBbhy_eZCY88a4CADQj2fKCuHsRnks5trEskgaJpZM4Teuw9.gif

theMK2k commented 6 years ago

I'll keep you posted about the Moby Link Detection for MAME Arcade. As soon as it is done, you'll get an intermediate build to test :)

aaronjsolomon commented 6 years ago

AWESOME

From: MK2k notifications@github.com Sent: Sunday, April 22, 2018 2:42 PM To: theMK2k/MetropolisLauncher MetropolisLauncher@noreply.github.com Cc: aaronjsolomon aaronjsolomon@gmail.com; Author author@noreply.github.com Subject: Re: [theMK2k/MetropolisLauncher] MobyGames link detection ineffective for MAME ROMs (#34)

I'll keep you posted about the Moby Link Detection for MAME Arcade. As soon as it is done, you'll get a intermediate build to test :)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/theMK2k/MetropolisLauncher/issues/34#issuecomment-383407002 , or mute the thread https://github.com/notifications/unsubscribe-auth/AkwiSL3GURoAEziRZt-EhnVUvBqnqwhWks5trN0WgaJpZM4Teuw9 . https://github.com/notifications/beacon/AkwiSAA0J9cae6IJfdbcLLMI-KdLDQH8ks5trN0WgaJpZM4Teuw9.gif

theMK2k commented 6 years ago

Done.

When the MAME Arcade platform is chosen, ROM Manager's Moby Link Detection functionality now takes the "Name" field for matching instead of "File", "InnerFile" or "Directory". This should easily match approx. 4000 titles with 100% accuracy.

To test this, you can use the following beta build:

https://metropolis-launcher.net/beta-releases/metropolis_launcher_1.2.0b1-mk2k.zip

Please back up your previous installation before overwriting any data.

aaronjsolomon commented 6 years ago

Ace!!

From: MK2k notifications@github.com Sent: Sunday, April 22, 2018 3:51 PM To: theMK2k/MetropolisLauncher MetropolisLauncher@noreply.github.com Cc: aaronjsolomon aaronjsolomon@gmail.com; Author author@noreply.github.com Subject: Re: [theMK2k/MetropolisLauncher] MobyGames link detection ineffective for MAME ROMs (#34)

Done.

When the MAME Arcade platform is chosen, ROM Manager's Moby Link Detection functionality now takes the "Name" field for matching instead of "File", "InnerFile" or "Directory". This should easily match approx. 4000 titles with 100% accuracy.

To test this, you can use the following beta build:

https://metropolis-launcher.net/beta-releases/metropolis_launcher_1.2.0b1-mk2k.zip

Please back up your previous installation before overwriting any data.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/theMK2k/MetropolisLauncher/issues/34#issuecomment-383411387 , or mute the thread https://github.com/notifications/unsubscribe-auth/AkwiSGeYzzaSdnDQQ-qOtDtMsCvO6Q3Uks5trO1HgaJpZM4Teuw9 . https://github.com/notifications/beacon/AkwiSACWYQgeeJUqrmV_aU8h5us6x-EEks5trO1HgaJpZM4Teuw9.gif

theMK2k commented 6 years ago

After testing, please post your results. So we can close the issue or do further work on it :)

aaronjsolomon commented 6 years ago

Question:

Do you prefer that issues in your issue tracker be treated as highly targeted for quick resolution, or more as a topic around which you’d like all related discussions to occur?

I have some closely related follow-up questions having to do with tweaking the UI and data handling. Would you like me to post them to the existing issue, or close the existing one and begin new issues?

From: MK2k notifications@github.com Sent: Monday, April 23, 2018 2:41 AM To: theMK2k/MetropolisLauncher MetropolisLauncher@noreply.github.com Cc: aaronjsolomon aaronjsolomon@gmail.com; Author author@noreply.github.com Subject: Re: [theMK2k/MetropolisLauncher] MobyGames link detection ineffective for MAME ROMs (#34)

After testing, please post your results. So we can close the issue or do further work on it :)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/theMK2k/MetropolisLauncher/issues/34#issuecomment-383483340 , or mute the thread https://github.com/notifications/unsubscribe-auth/AkwiSHIVUcnKeB4vo3TG-Wvx1OoS7IWkks5trYVvgaJpZM4Teuw9 . https://github.com/notifications/beacon/AkwiSI9DCzelZRYplVvEyKlKTfrfR5W0ks5trYVvgaJpZM4Teuw9.gif

theMK2k commented 6 years ago

I would suggest you report regarding the issue at hand and open a new one :)