search

theNewDynamic / gohugo-theme-ananke

Ananke: A theme for Hugo Sites
https://gohugo-ananke-theme-demo.netlify.com/
MIT License
1.13k stars 1.14k forks source link

parameterise colors and fonts #512

Closed tstephen closed 2 years ago

tstephen commented 2 years ago

I have replaced hard-coded fonts and colors with existing params and in one case introduced a secondary_text_color to allow things like RECENT POSTS to be differentiated from main headings.

Hope you find this acceptable.

budparr commented 2 years ago

Thanks, @tstephen I think this is fine. I've asked @regisphilibert to have a quick look.

regisphilibert commented 2 years ago

Hi @tstephen and thank you for this.

The purpose of the post_content_classes parameter is to customize the content of a post. By content we mean the body, not the title or the time. This current implementation applies the given classes to all those elements.

In the future we'll think of a better way to customize various fonts of the site, but I feel like this is not the right approach.

Now as for the introduction of secondary_text_color, I feel like we should discuss this on a ticket first in order poll the need for a second color and spec some directions for it.