search

theNewDynamic / gohugo-theme-ananke

Ananke: A theme for Hugo Sites
https://gohugo-ananke-theme-demo.netlify.com/
MIT License
1.13k stars 1.14k forks source link

Blog Featured Image stopped working #516

Closed mirontoli closed 2 years ago

mirontoli commented 2 years ago

Hi, I have used ananke theme since December 2021. Now when I updated it, my featured image stopped working.

The current code (not working) is https://github.com/theNewDynamic/gohugo-theme-ananke/tree/8fdfd205f9b4fd2f52eac9dfd2da8e11bea2015e

The previous working code was https://github.com/theNewDynamic/gohugo-theme-ananke/tree/c7b9901e01ec3720b47fcef3d33bdbd6ce53f000

My featured image is defined in config.toml (nothing changed since that day): 

[params]
  ...
  featured_image = "https://ik.imagekit.io/mirontoli/bridge_UngKtedn3OP.jpg?updatedAt=1639597203043"
regisphilibert commented 2 years ago

Hi @mirontoli and thanks for reporting. The global featured_image assignment using the site's Params was never documented and it made it very difficult to opt out of the global featured image on given posts. So we decided to ditch it in favor of the more broadly used cascade feature.

Cascade just applies a parameter to all the site's pages using cascade project configuration or to a a page's descendants (a section) using cascade Front Matter.

So from your config file adding the following will have the same effect:

cascade:
  featured_image: https://ik.imagekit.io/mirontoli/bridge_UngKtedn3OP.jpg?updatedAt=1639597203043

Let me know if this solves your problem adequately.

regisphilibert commented 2 years ago

Also are you using Ananke as a git submodule or as a Hugo Module? I'm asking because this change is not part of a release yet. By using Hugo Module, you ensure that any upgrade will be of the latest release rather than the latest commit.

mirontoli commented 2 years ago

I am using Ananke as a git submodule (right or wrong). I suppose you recommend using Hugo Module. I'll take look into it and the cascade configuration. Thank you very much for pointing me in right direction.

regisphilibert commented 2 years ago

I find it much more easier to use Hugo Module indeed, but to each his own. As a maintainer, I can push changes to master that might introduce breaking changes, but the only way I can communicate with the users about those potential breaking changes is using release notes at the time of the release, so I like the fact that the default Hugo Module update command will use the latest release (whose notes documents changes etc...)