theNewDynamic / gohugo-theme-ananke

Ananke: A theme for Hugo Sites
https://gohugo-ananke-theme-demo.netlify.com/
MIT License
1.13k stars 1.14k forks source link

Localize "By" #530

Closed regisphilibert closed 2 years ago

regisphilibert commented 2 years ago

If an author is set the page will mention them with the with the "By" preposition which had never been localized. I've proceeded to add it for the languages I'm familiar with.

If you've been mentioned in the following checklist, this means I identified you as the kind person(s) who initially or most recently updated the language's localization. Would you be kind enough to add you suggestion in the comments using this simple format: EN: By

If you have any reservations, for example the preposition needs to agree with gender or number in the given language, please let me also know in the comments.

Thank you all!

Fixes #528

netlify[bot] commented 2 years ago

Deploy Preview for gohugo-ananke-theme-demo canceled.

Name Link
Latest commit ea43359ed79c412dba865780f1c8a4e641081cf0
Latest deploy log https://app.netlify.com/sites/gohugo-ananke-theme-demo/deploys/624f2024e6da9500095b6a12
michael-on-github commented 2 years ago

UK: (no preposition)

winux1 commented 2 years ago

HU: (no preposition)

eddex commented 2 years ago

Hi there

It's true that I created quite a few translations in my commit a1500631c4b65960dd2eb85ca30b79be8347aa9 when I localized the form-contact shortcode. But I used https://deepl.com for most translations including NL and RU, so unfortunately I can't help with those.

ghost commented 2 years ago

JA: (no preposition)

xaner4 commented 2 years ago

NO: av

larihuttunen commented 2 years ago

FI: Not Applicable

https://en.wikipedia.org/wiki/Agglutinative_language

evrifaessa commented 2 years ago

I think Turkish is a bit different than the others.

"Made by {{x}}" translates to "{{x}} tarafΔ±ndan yapΔ±ldΔ±".

So the word is "tarafΔ±ndan". But the preposition comes before the verb, not the subject.

regisphilibert commented 2 years ago

Thanks @mivanchenko @winux1 @eddex @ssatosays @xaner4 @larihuttunen!

@evrifaessa the theme omits the verb altogether by simple writing "By John Smith". Do you think there is an application in Turkish or should we just print the name alone, like in many languages it seems.

evrifaessa commented 2 years ago

Thanks @mivanchenko @winux1 @eddex @ssatosays @xaner4 @larihuttunen!

@evrifaessa the theme omits the verb altogether by simple writing "By John Smith". Do you think there is an application in Turkish or should we just print the name alone, like in many languages it seems.

I think printing the name alone would be a better fit. Have a nice day :)

regisphilibert commented 2 years ago

Thank you! Looking at this and the fact that Hugo will fallback on the english translation if not found, I don't think we have a clear way to use a word in certain language and no word in other... (Unless testing the current languages in two lists of languages etc... a route I'm not willing to take).

I'm contemplating removing By in every language. @budparr what do you think?

budparr commented 2 years ago

I'm fine with that. Is there a way to not have it, but for someone to add it if they wanted to?

regisphilibert commented 2 years ago

I'm fine with that. Is there a way to not have it, but for someone to add it if they wanted to?

Not without overwriting the /layouts/posts/single.html, nope.

regisphilibert commented 2 years ago

Lots of back and forth but I chose to maintain current use, so we do have an exception on some language (to omit the print of a string). I also added a /_default/by.html template for straight forward overwrite by users.