search

theNewDynamic / gohugo-theme-ananke

Ananke: A theme for Hugo Sites
https://gohugo-ananke-theme-demo.netlify.com/
MIT License
1.1k stars 1.13k forks source link

Fix file permissions #581

Closed compwiztobe closed 1 year ago

compwiztobe commented 1 year ago

Someone's on Windows...

netlify[bot] commented 1 year ago

Deploy Preview for gohugo-ananke-theme-demo ready!

Name Link
Latest commit 04d98e1eebac8d958a71f7770633b69a37e8e21b
Latest deploy log https://app.netlify.com/sites/gohugo-ananke-theme-demo/deploys/6350fa19b474fc00084aa456
Deploy Preview https://deploy-preview-581--gohugo-ananke-theme-demo.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

regisphilibert commented 1 year ago

Hi @compwiztobe could let us know more about the motivation behind this PR. Your comment leaves a lot to interpretation.

compwiztobe commented 1 year ago

@regisphilibert pretty much just a style choice. Files coming from NTFS or FAT usually have the execute bit set (even when they originally came from linux), which if you expect it can be handled with clean up scripts or git config. But I noticed that already this repo has different execute bit values for different files which seem otherwise similar (probably someone on Windows committed these files from an NTFS file system without the relevant git config). So this change makes them consistent again (removing execute bit because it's not needed) to reverse that corruption and so it's more straightforward to detect/cleanup when your local repo/OS is corrupting it (all or nothing).

Related: https://git-scm.com/docs/git-config#Documentation/git-config.txt-corefileMode

regisphilibert commented 1 year ago

Thanks for clarifying and for the work!