theNewDynamic / gohugo-theme-ananke

Ananke: A theme for Hugo Sites
https://gohugo-ananke-theme-demo.netlify.com/
MIT License
1.1k stars 1.13k forks source link

Feature: Support rel="me" social links #587

Closed adambkaplan closed 1 year ago

adambkaplan commented 1 year ago

Fixes #417

netlify[bot] commented 1 year ago

Deploy Preview for gohugo-ananke-theme-demo ready!

Name Link
Latest commit 95d246eaad14f431b1316b1fb2c1ba7d12919082
Latest deploy log https://app.netlify.com/sites/gohugo-ananke-theme-demo/deploys/636da69793768e0008ee33a7
Deploy Preview https://deploy-preview-587--gohugo-ananke-theme-demo.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

adambkaplan commented 1 year ago

This tries to incorporate the feedback in https://github.com/theNewDynamic/gohugo-theme-ananke/pull/567#issuecomment-1238338612 by making rel="me" an opt-in feature.

Altonss commented 1 year ago

This has now been implemented in #596! This PR can now be closed @regisphilibert ;)

regisphilibert commented 1 year ago

Hi @Altonss damn I'm so sorry I did not see this PR before... I implemented a solution today which give full control of the rel attribute of the link. I'll review your PR later today and see what's best! I like that you have the mastodon built-in service default to using it.

Altonss commented 1 year ago

Hi @Altonss damn I'm so sorry I did not see this PR before... I implemented a solution today which give full control of the rel attribute of the link. I'll review your PR later today and see what's best! I like that you have the mastodon built-in service default to using it.

I'm not the autor of this PR, it's @adambkaplan :)

regisphilibert commented 1 year ago

Hi @adambkaplan! I think the solution retained in #596 will serve more use cases. Thanks a lot for your contribution though, and sorry for not having picked up on it earlier!