search

theNewDynamic / gohugo-theme-ananke

Ananke: A theme for Hugo Sites
https://gohugo-ananke-theme-demo.netlify.com/
MIT License
1.09k stars 1.12k forks source link

Support for dynamically localizing menus with i18n #627

Closed peterjochum closed 1 year ago

peterjochum commented 1 year ago

This PR adds support for an i18n identifier for items in the main navigation.

This is described in the Multilingual menus section of the Hugo documentation.

netlify[bot] commented 1 year ago

Deploy Preview for gohugo-ananke-theme-demo canceled.

Name Link
Latest commit 6b94d237d389c4ceb5ad41b4ddfa7c60c656a373
Latest deploy log https://app.netlify.com/sites/gohugo-ananke-theme-demo/deploys/63ff259f05560600087f1bf0
peterjochum commented 1 year ago

There remains a problem with the title attribute of the navigation links - it gets the untranslated name of the navigation link.

title="{{ i18n "pageTitle" . }}"

What is the title attribute for? Aside from adding the information its a "page" it does not contain additional information for users.

image