search

theNewDynamic / gohugo-theme-ananke

Ananke: A theme for Hugo Sites
https://gohugo-ananke-theme-demo.netlify.app/
MIT License
1.14k stars 1.15k forks source link

refactor: use the new twitter (X) logo #649

Open Nr18 opened 1 year ago

Nr18 commented 1 year ago

Since twitter updated it's logo it makes sense to update it in the theme.

netlify[bot] commented 1 year ago

Deploy Preview for gohugo-ananke-theme-demo canceled.

Name Link
Latest commit eebeb9a9dec6a5520c6036f16a0d2420d7be9e46
Latest deploy log https://app.netlify.com/sites/gohugo-ananke-theme-demo/deploys/6504831f1b7aaf0007239aa2
regisphilibert commented 10 months ago

Thanks @Nr18 . The theme is using disk icon with the logo inside... Could you provide something equivalent in size and shape? Thanks.

This does not look right: Capture d’écran, le 2023-11-21 à 14 39 35

Nr18 commented 9 months ago

Graphics is far from my expertise... You want it smaller or in a disk? The GitLab logo isn't in a disk either I noticed...

regisphilibert commented 9 months ago

The GitLab logo isn't in a disk either I noticed...

True, it's not a perfect system, but it still integrates nicely with the other icons. I guess my reluctance to approve this outright is triggered by the size and color of your proposition.

Capture d’écran, le 2023-12-15 à 13 12 41

Twitter/X is probably on 80% of Ananke sites, so I want to tread lightly.

Thanks for your understanding.