theNewDynamic / oregonsadventurecoast.com

2 stars 15 forks source link

Use Flickity for homepage carousel #63

Closed regisphilibert closed 4 years ago

regisphilibert commented 4 years ago

The current homepage carousel is implemented using an old jQuery plugin called cycle.

We need to use Flickity before we think about adding videos to the carousel.

The plan is to replicate the exact same behaviour as the current cycle implementation.

@mountainbug95 Even though Flickity has a jQuery initializer and this projects already uses jQuery I think we should use a vanilla implementation in case we decide to drop jQuery in the future for that project. Now if for some reason, vanilla would take you much more time than jQuery (don't see any reason why, as your midis implementation is vanilla but...) just let me know and we can review.

As always, if you feel blocked by tech or lack of information for more than an hour, it means it's time to hit me on slack...

Thanks

regisphilibert commented 4 years ago

Good now all we need is to make those fields surface in Forestry. @mountainbug95 would you mind trying to add Forestry fields in the code rather than having to do it after the merge in master.

Generally by looking at other Forestry yml filses you can get a sense of what you need to create a new FMT, Section etc...

And I'll make sure to thoroughly review the files added/edited on .forestry so don't be shy! We can always fix on master if something is not picked up right.

regisphilibert commented 4 years ago

@mountainbug95 one more thing. On mobile we see the image added to the slide rather than the video which is fine. Now could you make sure we also use the image as video cover so it's the first thing we see while the video is loading? I'll ask the client to use an image very close to the first frame of the video to use as image/cover.

But if they need the mobile image to be different than the video cover, they we might need an extra video field. So I think do this right now.