search

theOehrly / Fast-F1

FastF1 is a python package for accessing and analyzing Formula 1 results, schedules, timing data and telemetry
https://docs.fastf1.dev
MIT License
2.29k stars 239 forks source link

TrackStatus core #558

Closed formulatimer closed 3 months ago

formulatimer commented 3 months ago

Solve the issue last lap VSC Australia 2024

557

theOehrly commented 3 months ago

The comparison that you modified, while being correct, can actually be simplified to just compare against 'Time'.

I already started working on this in c59c2dc. There is more incorrect behaviour in some cases than just the last lap. So I fixed that as well, cleaned up the code and added a test for this. But I had even more test failures than you have here.

The test failures here are unrelated, so not caused by your changes.

I'd prefer to go forward with the changes that I had started working on to fix the other problems as well.

Sorry for the duplicate work, I wanted to reference the original issue in my commit so that it shows up in the issue that I had started working on this. But I forgot.

formulatimer commented 3 months ago

Great!

I needed some time to understand how it woked but with the comments you are added, the next time I will be faster.

I have reviewed your code and i believe it will solve the problem

If you need help do not hesitate to contact me