supremeremixx
commented
2 months ago Hello @theOehrly ! I made a little research so maybe this information will help you to fix this bug.
When I tried to run SignalRClient with timeout, after receiving an error and the timeout time has expired, the function client.start() was stucked in loop while self._connection.started in _supervise (livetiming->client.py).
async def _supervise(self):
self._t_last_message = time.time()
while True:
if (self.timeout != 0
and time.time() - self._t_last_message > self.timeout):
self.logger.warning(f"Timeout - received no data for more "
f"than {self.timeout} seconds!")
self._connection.close()
while self._connection.started:
await asyncio.sleep(0.1)
return
await asyncio.sleep(1)Apparently, since the connection has already been closed due to the error that occurred, the self._connection.close() function does not set the self._connection.started flag to False. For testing I manually added self._connection.started = False after close() function and SignalRClient was shutted down!
For another example, you can add these lines to the received message handler. If only the self._connection.close() function is there, I can see in the logs how the connection is closed, but the function remains in a blocking state (in fact it is a simulation of an error occurrence), but if you add self._connection.started = False after that, the function is terminated.
In normal conditions after self._connection.close() is called it trying to call self.__transport.close() (signalr_aio->transports->_transport.py) which is sents CloseEvent() to ws_loop.
def close(self):
asyncio.Task(self.invoke_queue.put(CloseEvent()), loop=self.ws_loop)And when _producer_handler receive this event it trying to close websocket connection and set self._connection.started = False (essentially the same behavior as in _supervise)
async def _producer_handler(self, ws):
while True:
try:
event = await self.invoke_queue.get()
if event is not None:
if event.type == 'INVOKE':
await ws.send(dumps(event.message))
elif event.type == 'CLOSE':
await ws.close()
while ws.open is True:
await asyncio.sleep(0.1)
else:
self._connection.started = False
break
else:
break
self.invoke_queue.task_done()
except Exception as e:
raise eSo as I understand this bug can be fixed by adding self._connection.started = False to some error handler of websocket connection. I tried to find it myself, but couldn't. That is why I decided to detail my observations for you.
Hope it helps!
theOehrly
Discussed in https://github.com/theOehrly/Fast-F1/discussions/627