search

thePaulV / Most-Recent-Tab

Firefox addon that adds a keyboard shortcut to switch back to your most recently selected tab. Useful to alternate between two tabs and to easily go back to your last tab if you switch to another briefly.
https://addons.mozilla.org/en-US/firefox/addon/most-recent-tab/
Mozilla Public License 2.0
12 stars 4 forks source link

No way to customize keyboard shortcut or detect conflicts WAS: Keyboard Shortcut Is not Working #1

Closed franzalex closed 6 years ago

franzalex commented 7 years ago

According to the description, the default key binding is Ctrl+Shift+1 on Windows systems. Unfortunately this key combination does not trigger any action on my computer. Clicking the button on the toolbar works though.

Can you please fix this or otherwise allow the user to remap the key binding to a different one?

EDIT
After reading the description in totality, I see you have indicated that the current framework doesn't allow customising keyboard shortcuts. Does this mean that the shortcut you indicated in the add-on's description is non-functional?

thePaulV commented 7 years ago

HI @franzalex, that's correct, unfortunately the new API is less flexible than the old one and there's no way to allow for customized keyboard shortcuts until bug 1303384 is fixed by the Firefox team.

In the meantime, I'd suggest seeing if you have any other extensions that have also requested the same shortcut and caused a conflict.

equalsJeffH commented 7 years ago

how might one easily "[see] if you have any other extensions that have also requested the same shortcut and caused a conflict" ? I'm on Mac OS and command + shift+ 1 is not working :(

thePaulV commented 7 years ago

Hi @equalsJeffH, user visibility into extension shortcuts is also part of bug 1303384 so in the meantime it would be about checking the documentation for your other extensions. Once bug 1320332 is fixed I'll be able to do more as the developer as well. Sorry I don't have better news yet, the WebExtensions APIs are still quite new.

thePaulV commented 6 years ago

This is resolved in version 2.0 in Firefox 60, thanks to the new commands.update API in Firefox. The addon now has a preferences pane where you can specify a custom shortcut.

as3mbus commented 6 years ago

when the version 2 going to be released ? i can only download version 1.1

thePaulV commented 6 years ago

Hi @as3mbus, Version 2 requires Firefox 60, which is scheduled to come out this week. I'll flip the switch in the addon once that happens.

as3mbus commented 6 years ago

ah i see. so that's why. i use nightly so i got confused when you say it's fixed in firefox 60 when i alrdy got nightly with version 62. cant wait to try it. thank you for your awesome work