search

thePaulV / Most-Recent-Tab

Firefox addon that adds a keyboard shortcut to switch back to your most recently selected tab. Useful to alternate between two tabs and to easily go back to your last tab if you switch to another briefly.
https://addons.mozilla.org/en-US/firefox/addon/most-recent-tab/
Mozilla Public License 2.0
12 stars 4 forks source link

Key combinations doesn't work in Firefox 52 #5

Closed manosnoam closed 6 years ago

thePaulV commented 6 years ago

Hi, thanks for reporting this. I just tested in Firefox 57.0.1 running on Fedora 27; both keyboard shortcut and toolbar worked.

Can you provide the versions you were using, or any further information that might be helpful in tracking it down?

thePaulV commented 6 years ago

Hi @manosnoam. I was not able to reproduce this bug. Closing for now, happy to reopen it if you can provide some more details on what versions of Fedora, Firefox and Most Recent Tab you were using.

manosnoam commented 6 years ago

Hi @thePaulV It happens to me on RHEL 7.4 with FF 52.6.0 (64-bit) - which is the latest supported version at the moment. Ctrl + 1 and Command-shift-1 doesn't work. Can I change key combination to test other keys perhaps ?

thePaulV commented 6 years ago

Thanks for the update @manosnoam. Looks like this probably broke when I added support for other addons to trigger the effect in v1.1. Testing a fix now.

thePaulV commented 6 years ago

After investigating and testing with Firefox 52 ESR, I think it's actually related to Firefox bug 1272198. Comment 9 in the bug suggests some combos that might work; I tested and confirmed that using Ctrl+Shift+F works.

Unfortunately there's no way to set the shortcut at runtime with the current Firefox APIs (see #1), but if you're comfortable building your own version of Most Recent Tab you can set Ctrl+Shift+F (or another working option) in manifest.json and you're good to go.

There's no general solution to this, so I'm closing as not fixable.

manosnoam commented 6 years ago

What if I use an additional plugin: https://addons.mozilla.org/en-US/firefox/addon/shortkeys/

It has option to add javascript as shortkey. Is there an option to call your shortcutHit() from an external javascript ?

manosnoam commented 6 years ago

Another plugin: https://addons.mozilla.org/en-US/firefox/addon/clut-cycle-last-used-tabs/

thePaulV commented 6 years ago

@manosnoam: Yes, version 1.1 supports triggering this addon from other addons. Here's how.

Also, Firefox 60 is supposed to be released this week, and it's an Extended Support Release version so hopefully you'll be able to upgrade on RHEL. That means a fix for the shortcut, plus support for setting your own using version 2.0.