search

theQRL / qrl-cli

7 stars 10 forks source link

Send quantity offline functionality #57

Closed afilis closed 3 years ago

afilis commented 3 years ago

Description

This feature allows you to save a transaction to a file on the computer that has been disconnected from the Internet. Then you can send the transaction to the network on the online computer.

Note: about half of the changed lines contain only extra spaces for code formatting.

Usage

Save to a transaction file: qrl-cli send <quantity> -r=<address> -i=<ots key> -w=<wallet> -T=<transation file>

Send from transaction file: qrl-cli send -m -F=<transation file>

jplomas commented 3 years ago

Nice PR

CI failing on the linting:

183:7   error  Unexpected if as the only statement in an else block  no-lonely-if
  369:27  error  Expected property shorthand

Given the utility this PR brings disabling the linting on those lines would be reasonable if you didn’t want a small refactor.

Thanks 👍

jplomas commented 2 years ago

:tada: This PR is included in version 1.9.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: