search

theRAPTLab / gsgo

GEM-STEP Foundation repo migrated from GitLab June 2023
1 stars 1 forks source link

Characters suddenly disappearing in pilot and aquatic charController on DO #146

Closed benloh closed 1 year ago

benloh commented 3 years ago

In GitLab by @jdanish on May 2, 2021, 10:00

I made some changes to the pilot script and it ran ok locally (except one time I noticed this issue locally but couldn't reproduce) but now on DO, none of the characters appear in the CharacterController or Viewer view except those added by that individual CC. They do appear in the window with the script editor and the main. This all started after I added the "decoration" characters, but it appears to now be a problem in the aquatic project too, so I am mostly sure it wasn't me.

To reproduce:

  1. Load main on DO (http://67.205.166.16/app/missioncontrol?model=pilot)
  2. Load a character controller (http://67.205.166.16/app/charcontrol)

See that the characters flash on screen and then disappear. This is sporadic - sometimes it seems fine but then reloading the window a few times causes it to happen again. I suspect there is a z-index issue - see attached where the flowers appear to have moved behind the bg?

Screen_Shot_2021-05-02_at_12.57.25_PM

benloh commented 3 years ago

So the problem is on the CharControl view? Not main?

It's probably related to slow updates of the background color. Most objects do not use zIndex at all, so they just get drawn on top according to their order.

I'll see if I can make sure the background is drawn behind.

benloh commented 3 years ago

In GitLab by @jdanish on May 2, 2021, 12:16

That’s correct- only In viewer and character controller, main looks fine. Thanks!

benloh commented 3 years ago

mentioned in commit 206468cb590f59235949182e0abe02d2cbd2631c

benloh commented 3 years ago

Should be fixed with 206468cb590f59235949182e0abe02d2cbd2631c The background color zIndex was not set properly. It didn't show up before because testing on fast networks the background would draw before agents.

benloh commented 3 years ago

In GitLab by @jdanish on May 2, 2021, 12:41

Awesome. That seems to have done it. I'll keep testing this can be closed (I only close the ones where you said to confirm and close on the assumption that you want the others open for some reason).

benloh commented 3 years ago

Actually the problem was more complicated than I thought at first. A few more fixes coming.

benloh commented 3 years ago

mentioned in commit 54972ed91152506796bcfda7c79c39b9b52a9b9e

benloh commented 3 years ago

mentioned in commit cd634b1d58030c4974e35c2d62a9b6bb034ae055

benloh commented 3 years ago

mentioned in commit 747398010ad3715774d89649cbcdf358d42bc163

benloh commented 3 years ago

@jdanish a few more fixes. Please try again to make sure it does fix the problem. It seems to be OK when I do it locally emulating a slow connection.

Please close if fixed.

zIndex documentation here: https://gitlab.com/stepsys/gem-step/gsgo/-/wikis/Scripting/ZIndex

benloh commented 3 years ago

In GitLab by @jdanish on May 2, 2021, 14:16

mentioned in commit 383500b8a36c02f819a063bfae778529ff63f941

benloh commented 3 years ago

In GitLab by @jdanish on May 2, 2021, 14:42

Looks good! Thanks!!