theRAPTLab / gsgo

GEM-STEP Foundation repo migrated from GitLab June 2023
1 stars 1 forks source link

Editing `ifExpr` inserts extra brackets {{ }} #418

Closed benloh closed 1 year ago

benloh commented 2 years ago

In the Script Editor:

  1. Create a new script line
  2. Add ifExpr
  3. Add a simple expression, e.g. a===b
  4. Click on the ifExpr slot
  5. Click on the expression a===b slot
  6. The edit text is now {{ a===b }}
  7. If you click save now, the expression will become: {{ {{ a===b }} }}

The brackets probably need to be stripped out before the expression is displayed in the element. The question is where should this happen? In the SlotEditorSelect_Block component's handler for expr? Should the token unitText itself not have the brackets?

benloh commented 2 years ago

In GitLab by @daveseah on Jul 14, 2022, 10:33

created branch 418-editing-ifexpr-inserts-extra-brackets to address this issue

benloh commented 2 years ago

In GitLab by @daveseah on Jul 14, 2022, 10:38

created branch 418-editing-ifexpr-inserts-extra-brackets to address this issue

benloh commented 2 years ago

Fixed with e85865aedcd249cbbd47b677d03357f35409ea89