Deleted blueprints reappearing

[benloh]

Blueprints that have been renamed or deleted are re-appearing as choices in EditSymbol.

To Replicate

1. Open a blueprint
2. Select the blueprint name and change the name to something else, e.g. from Fish to Shark
3. Save the line.
4. Add a new line
5. Set prop as the keyword
6. Select the object reference
7. In the list of "blueprints" that are displayed, "Shark" is properly displayed, and "Fish" is gone.
8. Click on the "agent" choice in the EditSymbol selector (not the "objref" slot at the top)
9. "Fish" will then suddenly re-appear in the list of blueprints.

Analysis

The reason for this is rather subtle and complex. Suffice to say slots_bundle is not properly updated with the newly revised cur_bdl. slots_bundle should always be revised whenever cur_bdl changes.

[benloh]

RAW NOTES

Select Line

1. EDITMGR.DispatchClick(tokenKey) => WIZCORE.SendState(sel_linenum)
2. EDITMGR.handleWizUpdate(sel_linenum) => SLOTCORE.SendState(slots_linescript)
3. EDITMGR.handleSlotUpdate(slots_linescript) => SLOTCORE.slots_bundle = WIZCORE.cur_bdl.clone() => SLOTCORE.SendState(slots_bundle, slots_validation)

• When the blueprint name is edited and saved (ac-editmgr.SaveSLotLineScript), we update WIZCORE state with new script_tokens.

• WIZCORE in turn detects the change in script_tokens and creates a new symbol bundle with the new blueprint name and deletes the old one, updating it's cur_bdl state to the new symbol bundle.

• Then when you select a new line (or add a new line), EDITMGR processes the click and updates WIZCORE with the selection.

• When EDITMGR sees that WIZCORE has a new selection, it tells SLOTCORE to update the slots_validation tokens reflecting the new selection.

• In order to generate the slots_validation tokens, EDITMGR needs the slot_bundle, which it tries to read from the current SLOTCORE state.

• The current slot_bundle in SLOTCORE is the bundle that was initially loaded when we first edited the blueprint name: the one with the old name.

• The slots_validation tokens reflect the correct list of blueprints (with the updated blueprint) because it is generated from the current WIZCORE state, which has the

• When you then click on the "agent" choice,

The slot editor keeps it's own copy of the current bundle slots_bundle that is separate from the wizcore bundle. The slots_bundle is updated with the change. So initially the list of available blueprints is correct.

[benloh]

Should be fixed with fdb87dc2da52b142560d65ab4c99d57be9d3ba91

[benloh]

mentioned in commit fdb87dc2da52b142560d65ab4c99d57be9d3ba91

[benloh]

See !256 for fix.