Closed benloh closed 1 year ago
In GitLab by @daveseah on Jan 13, 2021, 15:20
After discussion with Ben, I'm pushing for making a feat-template.ts
file with instructions for adding a feature to the system. It is pretty easy:
feat-template.ts
file and name it feat-whatever.ts
INSTANCE = new GFeature('FeatureName')
to what you want to call the feature in the script (e.g. useFeature FeatureName
)sim-features
to make it available to the sim engineI'll make these modifications and repush
In GitLab by @daveseah on Jan 13, 2021, 16:01
added 1 commit
In GitLab by @daveseah on Jan 13, 2021, 16:09
added 1 commit
In GitLab by @daveseah on Jan 13, 2021, 16:19
added 2 commits
In GitLab by @daveseah on Jan 13, 2021, 16:20
I've also renamed the Feature class to GFeature to help know when we're talking about a software feature versus the technical name of the implementation within the codebase. When we say 'feature' we mean the former, when we say 'geefeature' we mean the latter.
In GitLab by @daveseah on Jan 13, 2021, 16:20
The feat-template.ts
comments are a good place to start expanding the overall documentation for the rest of the team too!
In GitLab by @benloh on Jan 13, 2021, 17:21
Verified. Compiles and works.
In GitLab by @benloh on Jan 13, 2021, 17:21
mentioned in commit 90b354e0d65a8301a1c0882b9ff99ba2b39ebbb6
In GitLab by @benloh on Jan 13, 2021, 14:36
Add a new base
dev-sandbox
branch for developers and researchers to try out developing custom features.This also adds a new
feat-sandbox.ts
feature specifically for testing feature development without clobbering existing features.All developers should work off a branch of
dev-sandbox
. Prefix your branch withdev
and your initials, e.g. for Ben,dev-bl
.e.g. if Ben wants to try out a new feature
seek
, he'd:dev-sandbox
.dev-bl/seek
dev-sandbox
into your localdev-bl/seek
branch to keep up with changes.dev-sandbox
branch, create a Merge Request.In general, when playing with feature development the only file you need to touch ought to be
feat-sandbox.ts
. Keep in mind however, that other developers and researchers might also be modifyingfeat-sandbox.ts
.IMPORTANT:
dev-bl/seek
) should NEVER be merged directly intodev
, only todev-sandbox
.