Prototype Script Line Editor v2 - [merged]

[benloh]

Merges dev-bl/next-gui-slothelp -> dev-next-gui

This is a work in progress.

This cleans up the slot editor (right panel) and starts to lay out the key information components on the screen according to the Script Wizard Mockup (see #400). Most of the existing functionality should still work. Keywords other than prop are still not supported.

NOTES

• Errors and help text for each slot have been removed from the slot display and integrated into the choice / input display.
• Syntax remains above each slot.
• Slot help text is currently hacked in. When you hover over a choice selection, the help text should show information about the hovered object. If there's no hover, then the help should display information about the currently selected object.
• Selected keyword help text is also currently hacked in. When you select a keyword (the main verb of the script line), the slot editor should show a general help (and examples) explaining what the keyword is for and how to use it.
• The component and css hierarchies are still being worked out, but SelecttEditor, EditSymbol, and SelectEditorSlots have been rearranged.
• Some of the data/prop passing needs to be reviewed. A lot of it may not be necessary.
• See !218 for information about setting up test scripts.

[benloh]

@daveseah I expect to continue to work on this when I get back, but feel free to merge if it'll help you continue your work.

[benloh]

@jdanish This is obviously not finished, but it is mostly functional (still only for the prop keyword though), so you might give it a spin.

[benloh]

In GitLab by @daveseah on Jun 4, 2022, 12:17

It looks like a lot of the bits are in place. Main still seems to work as far as I can tell with the version of Aquatic Energy too, so I'll accept the merge!

For broader testing, maybe we can suggest that testers take low res screen recording with Quicktime Player as they're working and send us timestamps of where they experienced issues. Seeing the entire session that lead up to an error would make debugging go faster, and reporting might also be faster for the testers as well who no longer have to think of what they were doing or try to remember the specifics of it.

[benloh]

added 1 commit

• bdd2973e - next-gui-slothelp: Adjust connector edges to match slot. (was one pixel off)

Compare with previous version

[benloh]

In GitLab by @daveseah on Jun 4, 2022, 13:18

I have a laundry list of things to finish while you're gone. This is from the current hit list:

1. Symbol Helper Fixes

• [ ] Fixing objref variations - this means supporting Features
• [ ] Adding full gsType support - filling in al the handlers

2. Adding {value} assignments in prop keyword

This includes adding support for the {value} gsType, which can be a literal, expr, or objref

3. Adding {expr} support

This is the last major parsing feature, and may require rewriting the expression runner to understand objref syntax only.

4. Add call and if support

The call keyword works the same as prop. The if keyword is the first one to require blocks as part of its parameters, and requires {expr} support to work.

5. Add when 'blueprint context' support

This is a different kind of validation parser because of the test syntax being quite different from prop and call and statements in the consequent need to know what blueprints were mentioned in the parent when statement.

I think that finishes up all the engine stuff. We have the new line editing addition/deletion capabilities now with the new TRANSPILER EditableToken routines to plug into UI when you get back.

Accepting the merge!

[benloh]

In GitLab by @daveseah on Jun 4, 2022, 13:19

marked this merge request as ready

[benloh]

In GitLab by @daveseah on Jun 4, 2022, 13:20

approved this merge request

[benloh]

In GitLab by @daveseah on Jun 4, 2022, 13:20

mentioned in commit 7e37d7b1c4e993d9c6500c3ed48de34443ddc83f

[benloh]

In GitLab by @jdanish on Jun 4, 2022, 13:21

Dumb question, but what is a "slot"?

Also, I am not seeing help text / popup info. Not sure if I am misunderstanding or something is not working?

Thanks!

[benloh]

A "slot" is our dev nomenclature for the placeholder for each word in a gemscript line. End users probably won't have to use the word, but we might need to think through some of the naming.

There is no popup info at the moment, and the help text is baked in as a placeholder. This is more about positioning. We still need to add help to the data structures.

[benloh]

In GitLab by @jdanish on Jun 4, 2022, 14:09

Ahh ok thanks