FIX: #420 onEvent keyword does not execute all lines of code - [merged]

[benloh]

In GitLab by @daveseah on Jul 18, 2022, 10:00

Merges dev-sri/420-onevent-interim-fix -> dev-next-gui

Keyword onEvent Bug

There was a reported issue in #420 that code like this failed to function as expected:

onEvent Tick [[
  dbgOut "hello"
  dbgOut "is it me you're looking for"
]]

In the above, only "hello" would be output to the console, leaving the programmer to hum the second line and feel unfulfilled.

This is due to a bug in onEvent itself where it was using an old utility called derefFirstArg() which just uses the first element of an array. It has been removed

Simulator Control Cleanup

• Some dead/unused simulation modules have been removed because they were never used, or were replaced by more recent code.
• The core sim-rounds, api-sim, and mod-sim-control modules have been organized, linted, reformatted, and conformed to our current coding practice.

[benloh]

In GitLab by @daveseah on Jul 18, 2022, 10:01

marked this merge request as ready

[benloh]

@daveseah Actually I've been trying to convert all references to blueprint id or bpid to bpName. But hadn't gotten around to converting all the instances defs. Probably fine for now for consistency-sake.

[benloh]

Confirmed runs. Confirmed all onEvent lines run. OK to merge!

[benloh]

mentioned in commit 07024c28cba360a34a42bd987098dbe76d9ab28d