Convert student-facing agent to character - [closed]

[benloh]

In GitLab by @jdanish on Oct 2, 2022, 06:53

_Merges convert_agent_tocharacter -> dev-next

This was mostly a find-replace, but it changed a lot. Make sure to grab newest art-assets.

I've tested upcoming scripts carefully and it seems to have gone off without a hitch.

For version 2.0 we want to change the built in agent to character, but I didn't risk that. I figure that's an expert feature so it can wait.

[benloh]

In GitLab by @jdanish on Oct 2, 2022, 06:53

requested review from @benloh

[benloh]

In GitLab by @jdanish on Oct 2, 2022, 12:44

added 1 commit

• 04b1b9da - Quick fix to main page

Compare with previous version

[benloh]

In GitLab by @jdanish on Oct 2, 2022, 13:34

added 4 commits

• 04b1b9da...830e401e - 3 commits from branch dev-next
• 96fbce05 - Merge commit '830e401e8f7e4a1f99cd50f83cef1045cadbcbfb' into convert_agent_to_character

Compare with previous version

[benloh]

In GitLab by @jdanish on Oct 2, 2022, 14:04

added 1 commit

• 2696fe57 - Reverted accidental conversion

Compare with previous version

[benloh]

In GitLab by @jdanish on Oct 2, 2022, 14:17

added 1 commit

• 12af5cad - Joshua renaming methods to character from agent (not the properties as that's too big)

Compare with previous version

[benloh]

In GitLab by @jdanish on Oct 2, 2022, 14:27

added 1 commit

• 3295567d - Last reversions (we hope) back to Agent where Joshua was converting to...

Compare with previous version

[benloh]

In GitLab by @daveseah on Oct 2, 2022, 16:28

I did a quick review of what's in here up to "Last reversions (we hope) back to Agent where Joshua was converting to Character and shouldn't have been" and there are quite a few internal methods that got renamed and then renamed back. Not all of them are renamed back, and this means that someone will have to do a review of all the datacore modules and ensure they are consistent.

For example, there's this reversion:

-- function removeCharacter(instanceDef: TInstanceDef) {
++ function RemoveAgent(instanceDef: TInstanceDef) {
  SIMAGENTS.DeleteCharacter(instanceDef);
}

The name of the removeCharacter was changed, but the function itself is calling another renamed method called SIMAGENTS.DeleteCharacter(), so the fix is clearly incomplete.

The best way to clean this up is to walk all the importers of the various datacore and top-level modules and check each method using a very specific search term that uses the whole word, not partial words, and match case.