Fix Character Name Editing - [merged]

[benloh]

Merges dev-bl/fix-blank-char-name -> dev-next

Problem

When editing a character name in the Map SETUP, blank character names would result in characters disappearing from the CHARACTERS list. There were two issues here:

1. Selecting the name text and hitting "DELETE" or "BACKSPACE" would immediately save the name and close the editor, so you could not change the name anymore.
2. The character now has a blank name but is a valid instance, however the InstanceEditor was treating a blank name as an invalid instance and simply not displaying the instance. So once a character has a blank name you could no longer select it to edit it.

Solution

A few fixes:

• The InstanceEditor now shows "..." if the name is blank. This way the instance can still be selected for editing.
• Selecting the name and hitting "DELETE" or "BACKSPACE" no longer closes the editor because, because the blank name is no longer treated as an invalid instance.
• The propName, e.g. "Name", is now shown as a placeholder for InputField -- this doesn't affect functionality, but improves the UX.

NOTE because the list of characters is automatically ordered, when you change the name, your editor will shift in position. Unfortunately it's not easy to fix this without changing the way the whole panel is rendering.

[benloh]

requested review from @jdanish

[benloh]

In GitLab by @jdanish on Oct 26, 2022, 13:09

Looks good! Thanks!

[benloh]

mentioned in commit 25b9d74d0bcc2507da40794f11d0b724844f1f77