ScriptEditor UI Fixes - Githubissues

theRAPTLab / gsgo

GEM-STEP Foundation repo migrated from GitLab June 2023

1 stars 1 forks source link

ScriptEditor UI Fixes #761

Closed benloh closed 10 months ago

benloh commented 11 months ago

A few minor Script Editor improvements:

The Script Editor now has a vertical dragger to resize the script and line views (#749):
Blueprints can now be selected directly in the Script Editor view (#750) via a popup menu.
The Main screen's sidebars can also be resized: A few notes:
- The "MESSAGES" panel has been hidden -- messages can be restored by uncomment the components. See ae3c8a394f6258564cb551e5b6b690765ebaddce
- Because the simulation screen ratio is set to 1:1 and because the graphs are displayed to the right of the simulation (strictly speaking outside of the simulation screen), dragging the sidebars to be too narrow can hide the graphs. A proper fix for this probably involves introducing a special area for graphs.

benloh commented 11 months ago

@jdanish a few ScriptEditor and Main UI fixes. Please give it a whirl.

jdanish commented 11 months ago

Mine loads like this for some reason?

See the drag bars on right?

Screenshot 2023-08-05 at 8 40 50 AM

jdanish commented 11 months ago

The resizing in script editor and jump to script work great.

jdanish commented 11 months ago

For now I am OK leaving the graphs where they are because we can always do a different stage and / or adjust the window as needed to make that work better. But I agree, long-term we'll need to think about that.

benloh commented 11 months ago

@jdanish sorry, I was working on the best way to fix the width issue and forgot to commit one line. The drag bars should be right now.

Also tightened up the spacing so dragger bars don't have extra padding.

jdanish commented 11 months ago

All good. Seems to work well now! One minor thing - when I drag the bar on the right, it appears to drag about 100-200 pixels left of where the mouse is. Is that happening to you?

benloh commented 11 months ago

Hmm...I thought I had fixed that as well. Don't accept the pull request. I'll fix it when I get back. Are you seeing this with various window sizes and/or with developer mode/console visible?

jdanish commented 11 months ago

Various window sizes in chrome without the debug panel open though I usually move between them. If it will help I can test other configurations.

benloh commented 10 months ago

@jdanish I think the right dragger should be fixed by 53407e655dfe34a6b20fec1b84c9c8e3d0fd764f

jdanish commented 10 months ago

Confirmed. Looks good.