theRAPTLab / gsgo

GEM-STEP Foundation repo migrated from GitLab June 2023
1 stars 1 forks source link

PanelRounds is using `round.id` but `id` is not defined #790

Closed benloh closed 7 months ago

benloh commented 8 months ago

Rounds can be defined with out an id. If this happens, then PanelRounds will emit a "should have a unique key prop" error.

The main issue is that if there is more than one round defined, SAVING the project settings will result in endScripts being deleted.

benloh commented 8 months ago

NOTES

round.id should be identified and used for selection.

Do we want to change to an id-less approach so that it can more gracefully degrade if id is not defined? Or do we need to require an id?

benloh commented 7 months ago

Fixed with 4c8a1b1193aa5517b75cf05adc156a8c1e0198ab