theRAPTLab / gsgo

GEM-STEP Foundation repo migrated from GitLab June 2023
1 stars 1 forks source link

Code bookmarks now showing up consistently #792

Open jdanish opened 8 months ago

jdanish commented 8 months ago

They don't always come up immediately when the page loads, but clicking on code view then back will load them. Also, not all are loading. I made a video that I am sending via slack.

jdanish commented 8 months ago

Slack link: https://inquirium.slack.com/archives/C01J8G6FRK2/p1697629995509479

benloh commented 8 months ago

This looks like an asynchronous load issue.

Note also that _comment_types.toml needs to be re-built whenever you change it (you can just stop and restart the server). Because this is in art-assets the auto rebuild doesn't work -- a simple page reload will not re-read the comment type definitions.

This should be fixed with 0b698f4144654f63f3b642b584fef6538cee705d