search

theRAPTLab / meme-2023

MEME 2023 grant development (fork from MEME 2018)
MIT License
0 stars 0 forks source link

Remove regression: extra Express server started during build scripts #14

Closed villagrat closed 4 weeks ago

villagrat commented 4 weeks ago

This pull request fixes both cleaning scripts from the project being broken (see issue #11). It removes an incorrect call to start the express server whenever the file was imported, which resulted in either the npm run clean script never finishing or other various errors for npm run clean:all

New Changes:

Testing Instructions:

  1. Pull this branch locally and switch to it.
  2. Run the cleaning scripts with npm run clean and npm run clean:all.
  3. Verify that no errors are returned.
  4. Verify that other scripts (npm run dev, npm run start, etc) still work as expected

Technical Background Info: The express server was previously started whenever server-express.js was imported due to an incorrect call. This has been fixed by removing the automatic call and only starting the server when the Start() function is called.

villagrat commented 4 weeks ago

Reviewing other open issues, it is possible that this small change also partially fixes issue #10 (incorrect multiple webpack calls)

The npm run package behaviour item of the issue remains to be tested though