Closed goleary closed 3 years ago
Hey, thanks for the interest! I double checked the Diffbot documentation, and can't find mention of paging
being used for the Analyze API in either of their documentation sites (https://www.diffbot.com/dev/docs/analyze/ or https://docs.diffbot.com/docs/en/api-analyze). I can add the paging
param to the analyze API as you've outlined, but I just want to first confirm that it does exist for that endpoint and works identically (for the JSDocs). Do you have a link to where that param is defined for the analyze API, or is it the exact same behaviour from what you can tell?
Great call out. I was hoping to be able to point you at docs that detailed this usage when I opened this issue but was unable to find any π¬
From my testing it exhibits the same behaviour when analyze routes to the article product.
I have an ongoing email thread with diffbot support who recommended I use it with the analyze endpoint which is what led me here.
I've put this issue on their radar, so perhaps someone from diffbot will chime in.
Thanks for the quick response!
@theRealPadster I have been unable to drum up any support from diffbot on this, but I can confirm that it behaves as I mention above when &paging=true
is passed to the analyze endpoint.
I'm happy to draft the PR if you're open to accepting.
Sorry, yeah I was waiting to see if the Diffbot team would say anything. I have merged it in, and I'll publish it on npm now :) Thanks!
Awesome, thanks a ton!
Hi! π
Firstly, thanks for your work on this project! π
Today I used patch-package to patch
diffbot-api-node@0.3.6
for the project I'm working on.Paging can be passed as query param to both the analyze & article endpoints, but this client doesn't expose it as an option for analyze.
Here is the diff that solved my problem:
This issue body was partially generated by patch-package.