search

theRealPadster / spicetify-hide-podcasts

Spicetify extension to hide podcasts
GNU General Public License v3.0
249 stars 14 forks source link

Extension does not work #133

Open tsuliwaensis opened 8 months ago

tsuliwaensis commented 8 months ago

🔍 Is there already an issue for your problem?

ℹ Environment / Computer Info

- Spotify version: 1.2.32.997.g4c6498b6 [macOS]
- Spicetify version: 2.33.2

📝 Description

The extension appears in the profile menu but nothing happens when you try to enable it. A checkbox doesn't appear next to "Enabled" and Podcasts are still appearing.

📸 Screenshots

No response

jpsirois commented 8 months ago

Doesn't work for me either :( Screenshot - 2024-03-13 at 09 38 09@2x

theRealPadster commented 8 months ago

Are you running the latest version of the extension? I'd suggest installing it locally (remove from Marketplace and install manually) to be sure. The latest version of Spicetify fixed a bug where it wasn't showing checkmarks in menu items, though they still functioned. Now it looks like it shows the checkmark when you click it, but not on first load of Spotify. If you go to the search page, and toggle the extension on and off a few times, it should hide/show a few of the genre cards. Can you test this?

theRealPadster commented 8 months ago

Fix for initial menu item state is in this commit. Will need to wait for next spicetify release for that.

https://github.com/spicetify/spicetify-cli/pull/2905

tsuliwaensis commented 7 months ago

I reinstalled Spicetify (version 2.35.1) and Marketplace and the extension sort of works. I don't see the Podcast in the home page anymore, but the buttons still appear on the home page and the sidebar.

theRealPadster commented 7 months ago

I reinstalled Spicetify (version 2.35.1) and Marketplace and the extension sort of works. I don't see the Podcast in the home page anymore, but the buttons still appear on the home page and the sidebar.

Can you post a screenshot? I'm not sure what buttons you're referring to.

tsuliwaensis commented 7 months ago

I have a theme applied and that might be the reason why it's not being hidden

2024-03-22_08-44-20

theRealPadster commented 7 months ago

I have a theme applied and that might be the reason why it's not being hidden

2024-03-22_08-44-20

Is the rectangle part this UI element? What theme are you using? Can you post a bigger screenshot? image

theRealPadster commented 7 months ago

It looks like I just don't have that UI on my Spotify for some reason.

Someone on discord shared the UI element, so I might try and add something to block it when I have a chance (in the next few days) but hard to test without having it on my Spotify. 

<button role="checkbox" aria-checked="false" aria-label="Podcasts" data-encore-id="chip" class="Chip__ChipComponent-sc-ry3uox-0 ChipComponent-checkbox-chip-useBrowserDefaultFocusStyle"><span class="ChipInner__ChipInnerComponent-sc-1ly6j4j-0 ChipInnerComponent">Podcasts</span></button>
tsuliwaensis commented 7 months ago

I removed the theme and it's still there. I'm on a Mac, if that makes a difference. Here's a fullscreen screenshot

2024-03-24_08-59-35

theRealPadster commented 7 months ago

Yeah I still don't have this UI. Marking as blocked for now.

80H-d commented 4 months ago

image on windows 11 /shrug

theRealPadster commented 4 months ago

image on windows 11 /shrug

Yeah I've got that UI on my W11 now. I don't have podcasts or audiobooks there though, I'd guess because I've never interacted with them before. I looked at the way the ones that I do have are set up, and got it working to hide those ones, then adjusted it to be for podcasts + audiobooks. That's been updated in the latest hidePodcasts.js file. Could you give it a try?