theRealRobG / PFInterstitials

An attempt to polyfill the functionality of HLS Interstitials to versions of iOS/tvOS before the introduction of AVPlayerInterstitialEventController
0 stars 0 forks source link

Code coverage on PFInterstitialEventController is incomplete #12

Closed theRealRobG closed 3 years ago

theRealRobG commented 3 years ago

When PFInterstitialEventController was introduced in https://github.com/theRealRobG/PFInterstitials/commit/c6c7929ff28e9282a1a16333757efe2aef75bf0a, it was noted that some test coverage was missing, but that it would be completed later. At the time I just wanted to get what I had working uploaded but this situation should not continue for long, as there may be some significant refactoring coming, and so we'll need confidence in making changes during that period.