search

theRookieCoder / SnowyLeavesPlus

When it is snowing, leaves will slowly turn white, and when it is not, they will turn back to normal
https://modrinth.com/mod/snowyleavesplus
Mozilla Public License 2.0
12 stars 3 forks source link

v0.1.3 is broken due to falsely inverted if-condition #11

Closed Fuzss closed 1 year ago

Fuzss commented 1 year ago

Hi, due to this if being inverted the mod is currently broken on the latest version: https://github.com/theRookieCoder/SnowyLeavesPlus/blob/9b18107e37643cb93a4f0a1128950125bb652c03/src/main/java/io/github/therookiecoder/snowyleavesplus/mixin/LeavesBlockMixin.java#L49

I was also wondering if you are aware that the Snow Day mod copies your whole mod? The classes are all the same, just a little rearranged and some stuff renamed. Technically also breaks your license as there is no license notice on the classes or anything like it. And no credit given.

theRookieCoder commented 1 year ago

Snow Day mod copies your whole mod?

Thank you so much for bringing this to my attention! I have made reports on both CF and MR, not sure how to contact the author cause his repo doesn't have issues enabled. While the mod does have other functionality, it would've been easy enough for the author to suggest my mod. If he had any issues with my code, he could've even made pull requests on this project.