search

theUpsider / ComfyUI-Logic

Logic nodes to perform conditional renders based on an input or comparision
125 stars 17 forks source link

Can't load the nodes #13

Open rfc82 opened 1 month ago

rfc82 commented 1 month ago

Describe the bug When load the workflow, the nodes appear in red. Try install via manager and manually

To Reproduce workflow-horrify-anything-juYDgWeKoe69e6vatBeG-lordtzeentch-openart.ai.json

Expected behavior A clear and concise description of what you expected to happen.

Screenshots nodes

Version:

Additional context Add any other context about the problem here.

theUpsider commented 1 month ago

Try adding the nodes again. I changed the names to avoid duplicates globally.

patrice74 commented 1 month ago

This latest version no longer works with https://github.com/vivax3794/ComfyUI-Sub-Nodes. This is due to the character used in the name change: If ANY return A else B-🔬 Just rename it, for example: If ANY return A else B-22

theUpsider commented 1 month ago

@patrice74 Thanks for pointing that out. Im struggling whether i should rename them again or leave them with the naming as is.

patrice74 commented 1 month ago

Personally I would rename it without adding special characters, to maintain the greatest compatibility with the other nodes

theUpsider commented 1 month ago

@patrice74 But i would have to rename it again, making it tedious for everyone who already adapted their naming.

Yaeph commented 6 hours ago

Em...so if I have 5 large workflows with ~30 logic nodes I need to recreate all those nodes in all workflows? is there an easier solution?

theUpsider commented 6 hours ago

@Yaeph I'm thinking about a solution for this. I have the idea of building an easy upgrader module which allows people to update their repositories. I will try to implement a first prototype next week. Currently I'm on a business trip until Sunday. Hope that's fine.

theUpsider commented 6 hours ago

@Yaeph you can do a temporary fix: downgrade my module for now. Download a version on which the naming is still the old one. You can check it, as the names originally didn't have this emoji: 🔬and the dash - in front. So if the node is now called: Bool-🔬 it was originally Bool

This is a temporary fix. I will try to build an updater next week. This is a general problem for comfy ui and not tailored to my repository.