search

theVolary / feather

Full featured widget-based RIA framework for node
Other
16 stars 19 forks source link

corrected use of existsSync to use fs #302

Closed DavidZey closed 9 years ago

zero5100 commented 9 years ago

fs.accessSync() is the recommended replacement for fs.existsSync().

http://nodejs.org/api/fs.html#fs_fs_accesssync_path_mode

skrenek commented 9 years ago

For node v0.12.0, sure. We still need to support v0.10.x though for a while.

selevanm commented 9 years ago

Andy fixing feather like a boss

Sent from my iPhone

On Feb 19, 2015, at 3:14 PM, Steve Krenek notifications@github.com wrote:

For node v0.12.0, sure. We still need to support v0.10.x though for a while.

— Reply to this email directly or view it on GitHub.

chris-held commented 9 years ago

This is probably the most activity a feather PR has ever seen, and it's for like the most minor change ever. :)

zero5100 commented 9 years ago

Hahaha what have I done.

selevanm commented 9 years ago

Made feather relevant again is what you have done!

----- Original Message ----- From: "zero5100" notifications@github.com To: "theVolary/feather" feather@noreply.github.com Cc: "selevanm" selevanm@gmail.com Sent: Thursday, February 19, 2015 6:32:00 PM Subject: Re: [feather] corrected use of existsSync to use fs (#302)

Hahaha what have I done.

— Reply to this email directly or view it on GitHub .

skrenek commented 9 years ago

All it needs now is a genuine issue logged from the public.

selevanm commented 9 years ago
----- Original Message ----- From: "Steve Krenek" notifications@github.com To: "theVolary/feather" feather@noreply.github.com Cc: "selevanm" selevanm@gmail.com Sent: Thursday, February 19, 2015 7:06:09 PM Subject: Re: [feather] corrected use of existsSync to use fs (#302) All it needs now is a genuine issue logged from the public. — Reply to this email directly or view it on GitHub .
DavidZey commented 9 years ago

I would create a another account in github and create an issue to make that look like it happened, but that's just too much work. Sorry Matt, you will start breathing again once you pass out. :)

On Feb 19, 2015, at 9:06 PM, selevanm notifications@github.com<mailto:notifications@github.com> wrote:

----- Original Message ----- From: "Steve Krenek" > To: "theVolary/feather" > Cc: "selevanm" > Sent: Thursday, February 19, 2015 7:06:09 PM Subject: Re: [feather] corrected use of existsSync to use fs (#302) All it needs now is a genuine issue logged from the public. — Reply to this email directly or view it on GitHub . — Reply to this email directly or view it on GitHubhttps://github.com/theVolary/feather/pull/302#issuecomment-75182784.
selevanm commented 9 years ago

Thanks I was starting to turn blue

On Sat, Feb 21, 2015 at 10:52 AM, David Zey notifications@github.com wrote:

I would create a another account in github and create an issue to make that look like it happened, but that's just too much work. Sorry Matt, you will start breathing again once you pass out. :)

On Feb 19, 2015, at 9:06 PM, selevanm <notifications@github.com<mailto: notifications@github.com>> wrote:

----- Original Message ----- From: "Steve Krenek" > To: "theVolary/feather" > Cc: "selevanm" > Sent: Thursday, February 19, 2015 7:06:09 PM Subject: Re: [feather] corrected use of existsSync to use fs (#302) All it needs now is a genuine issue logged from the public. — Reply to this email directly or view it on GitHub . — Reply to this email directly or view it on GitHub< https://github.com/theVolary/feather/pull/302#issuecomment-75182784>. — Reply to this email directly or view it on GitHub https://github.com/theVolary/feather/pull/302#issuecomment-75386232.