search

theZiz / aha

Ansi HTML Adapter
Other
915 stars 88 forks source link

Bold doesn't appear to reset #24

Closed eanderson4 closed 7 years ago

eanderson4 commented 7 years ago

Issue: In my terminal, the output of my npm run has only 1 word in bold. The output in my html file after running aha has all the following words in bold as well.

see dump of files here: https://gist.github.com/eanderson4/807cc5dc676e8be291863c0bc043aa33

I run the following command to keep the ansi escape characters in a log.

$ unbuffer npm start > npm.log $ cat npm.log | ./aha > npm.html

In the terminal, only 'Access URLs:' appears to be bold. However, in the html file, every word that follows is in bold. I don't really know much about these ansi characters to debug anything so I was wondering if there is any obvious mistake I was making in this.

$ ./aha --version Ansi Html Adapter Version 0.4.10.3

And thank you for this program, it is very useful! Much appreciated.

Eric

theZiz commented 7 years ago

Thanks for the bug report. Could you also provide me the "npm.log", I have neither unbuffer nor npm installed. :)

eanderson4 commented 7 years ago

Here is the log file https://gist.github.com/eanderson4/807cc5dc676e8be291863c0bc043aa33#file-npm-log

Let me know if issues with it. Thanks for the quick response!!

theZiz commented 7 years ago

Sorry for the late respone time, I will have a look at this bug today or the weekend. ;)

theZiz commented 7 years ago

Sorry for the late answer, I had less time on the weekend than expected. I fixed it: https://github.com/theZiz/aha/commit/38db4c1fbb3a32669e823ef1c35d7b1f7fc62547 I just forgot to check for the command 22: reseting bold text, I did only check for command 0 (reseting everything) and 21 (resetting bold and double underline)

eanderson4 commented 7 years ago

It looks like it is working, thanks for the fix!