Fix Calling limit with count returns unexpected results #54

[esmarkowski]

This pull request fixes the issue where calling limit with count returns unexpected results in the CrashEvent class. The issue was caused by the size parameter being deleted in the count! method. This pull request adds the default_size to the query builder and fixes the deletion of size in the count! method.

Here's what's happening:

• CrashEvent.limit(2).count has no query conditions.
• We remove size before calling the elasticsearch count API endpoint.
• The count API endpoint uses match_all: {} if there are no query conditions.
• That means all documents are counted

When we provide a query without limit

• CrashEvent.where(operator: "American Airlines").count
• The count API endpoint uses the condition and returns the document count matching the query

When we provide a query with a limit

• CrashEvent.where(operator: "American Airlines").limit(2).count
• Then the user doesn't really want to use the count API endpoint, they want to limit the results to two that match their query
• But we remove :size because it's a count request

Solution

• We add default_size to relation @values[:default_size]
• When search_options are built in QueryBuilder
  • if count? is false
    • Set size to the user provided values[:size] OR default_size
      • if count? is true
      • set size to nil preventing it from being added to search_options
• When size is set and count is called we return results.count instead of count! (which calls the Count API endpoint)

Fixes #54