theacodes / cmarkgfm

Python bindings for GitHub's cmark
MIT License
69 stars 26 forks source link

Add GitHub Actions #27

Closed mbarkhau closed 3 years ago

mbarkhau commented 3 years ago

Fixes #22

Status

Haven't looked too much into it yet, but I'll see if I can get MacOS and Windows working with the multibuild repository (possibly also replace the existing manylinux stage if it makes things more simple).

fruch commented 3 years ago

Looks like a good direction, i.e. keeping it in the same repo and using github actions.

I think this multibuild might be a bit of a deadend, and maybe was a nice a idea.

But I think cibuildwheel is a bit more clean solution https://cibuildwheel.readthedocs.io/en/stable/setup/#github-actions

I was using it ontop of Travis.CI, and lot of the know how on how to build wheels correctly in multiple os and multiple python version is embedded into that project.

Here is how I used it: https://github.com/scylladb/python-driver/blob/master/.travis.yml

fruch commented 3 years ago

@mbarkhau Here it's running now with my fork

https://github.com/fruch/cmarkgfm/pull/1/commits/0c2d1c2e960256fae45c987f884825bef5132473

https://github.com/fruch/cmarkgfm/actions/runs/379878422

and tarball with all the wheels can be download, now just need to fit it to a release to pypi, and it's ready :)

mbarkhau commented 3 years ago

Very cool, I'll check it out tomorrow.

mbarkhau commented 3 years ago

@theacodes I think this is ready for review whenever you have time.

mbarkhau commented 3 years ago

Unfortunately, I can't test the upload itself, if there is any issue, this may be of help: https://github.com/joerick/cibuildwheel/blob/master/examples/github-deploy.yml