theahura / shoot-the-messenger

Script to auto-unsend all messages from a facebook messenger chat
Other
189 stars 28 forks source link

ERROR: something went wrong. Failed to complete removal + not all messages are deleted -> Any tips to overcome those issues ? #119

Closed Eminmpenza closed 1 month ago

Eminmpenza commented 3 months ago

Describe the bug

Hi, Firstly, I would like to say that I'm very grateful about this script and I would like to thank his creator for his amazing job. It really helps and saves me a lot of time ! The "bugs" that I'm talking about here have already been discussed in some others reports.

The main problem is the script will eventually stop at some point and the following message will appear :

ERROR: something went wrong. Failed to complete removal

I have to relaunch the script any time it does this, and it will work fine until the same message shows again. I am currently deleting a long conversation that includes many years of chat, and I can't really launch the script and do something else because I have to be around and be ready to relaunch it when necessary.

The second problem is that the script won't always delete all messages, and it can skip a few (sometimes more than a few) in a row. It also makes me relaunch the script several times where it has already been running to unsend the remaining skipped messages. I can also delete those skipped messages manually.

To Reproduce Steps to reproduce the behavior:

  1. Go to : https://www.messenger.com/ and select a conversation chain
  2. Click on the "shoot-the-messenger" extension and then on "Remove Messages"
  3. Let the script run for a while
  4. The script stops and a small window displays "ERROR: something went wrong. Failed to complete removal"
  5. Check for messages that have been skipped (not unsent) by the script
  6. Start to run the script again from where it stopped and/or where it left some messages not unsent

Expected behavior The script runs and unsends all the messages without interruption until none of the messages remain. In others words, the user has to start the script one time and only one time (for a given conversation chain) and can let it run until full unsending of all messages has been completed. No other runs are necessary to handle a given conversation chain. The script won't skip any messages to unsend.

Screenshots image image

Desktop (please complete the following information):

Logs shoot-the-messenger-bug.txt


I know it has already been discussed, but I am not able to find any solutions to those two problems. Does anyone have tips or advice to improve the script efficiency or at least diminish at most the interruptions and/or the skipped messages ?

I would gladly appreciate it !

Thanks in advance.

theahura commented 2 months ago

im recently funemployed so I have some more time to support this! will try and see whats going on today

theahura commented 2 months ago

ok so wrt skipping messages, that's a tough bug to replicate. I sent myself something like 200 test messages and in that list, it skipped over one of them. First I was like, 'o that's a problem'. But then the system fixed itself on the next cycle, without any manual intervention. Are you sure that shoot the messenger does not eventually circle back to delete the messages that you think are being skipped over?

theahura commented 2 months ago

WRT the 'something went wrong' message, can you send over additional logs? Those are located on the bottom right of the screen and it should help indicate why it failed

theahura commented 2 months ago

ok getting closer to a few culprits

Eminmpenza commented 2 months ago

Are you sure that shoot the messenger does not eventually circle back to delete the messages that you think are being skipped over?

No, the skipped messages stay that way and the script never goes back on its own to remove them. If I want those skipped messages removed, I have to run the script again back from where the messages were left unremoved.

ok getting closer to a few culprits

* seems like the search feature isnt working (this thing always breaks tbh) which might be causing the 'something went wrong' errors

* independently it looks like sometimes the system highlights messages from _other_ people accidentally, which causes problems because it thinks its deleting your message but it doesn't actually do so

Yes, you nailed it. It's exactly what it does. In my first post, I failed to mention it sometimes deletes other people messages and not mine for some reason.

WRT the 'something went wrong' message, can you send over additional logs? Those are located on the bottom right of the > screen and it should help indicate why it failed

The conversation I have been deleting is almost fully removed from my messages.

I'll try to run the script on another one, and I'll keep you updated with the new logs it generates.

Thanks for your answer and your work !

theahura commented 2 months ago

ok I just pushed a bunch of fixes that I think should solve both of these issues. LMK if this is still causing problems on your end

i also added the ability to start from a particular text string, so hopefully that will make it easier to deal with restarting off a really long text chain

Eminmpenza commented 2 months ago

Thanks !

I have tested the new version which seems to work fine for a while until a new kind of error pop up.

image

The page now shows "couldn't load chats" error message.

I'm gonna try to run it again a few times to come with logs information about what goes wrong.

Eminmpenza commented 2 months ago

Thanks !

I have tested the new version which seems to work fine for a while until a new kind of error pop up.

image

The page now shows "couldn't load chats" error message. I'm gonna try to run it again a few times to come with logs information about what goes wrong.

image

Log related to the new error.

It seems to always crash just after the script points one of my already unsent messages, as it would like to remove it, but instead, the script would try to prevent to remove it (where it was sometimes removing my already unsent messages before your last fix) and this seems to cause the error.

Let me know if you need more informations about the logs and feel free to let me know how to properly report them here because I am not a developper and I may not give your the right informations as you would expect them.

theahura commented 2 months ago

O yea that's because the script is trying to hide all the 'you unsent a message' rows and there are too many that fb gets tripped up :thinking: let me take a look again

theahura commented 2 months ago

Just pushed a new update, check that out. Also includes a 'delete all' mode

Eminmpenza commented 2 months ago

Hi, thanks for your update.

Seems like it's still glitching after a while. I run the default mode, and it was working fine until it wasn't anymore. I recorded to show you what happened.

https://github.com/user-attachments/assets/fc7e1342-dfbd-4a8a-9e15-3ff4ef23344f

image

theahura commented 2 months ago

huh! that's pretty weird! no idea why it's doing that, will have to dig into it. Those logs also seem pretty...empty? there should be more there :thinking:

Eminmpenza commented 2 months ago

I run it again until it did the same bug.

Are you able to see what's going on with those ?

image image

theahura commented 1 month ago

@Eminmpenza can you confirm this is still happening on your end? I'm still not able to replicate

bluevex commented 1 month ago

I'm getting this error, latest chrome latest version on chrome store - the script fails in two ways for me. The first is this one, the "ERROR: something went wrong. Failed to complete removal." after clicking the dialogue, "Completed runner iteration but did not finish removal. Could not find searchable message..." is printed. The second failure mode is when it identifies and searches a string, but facebook does not return the result it should in the search window. I can solve this one by re-searching or randomly removing words in the search string until facebook properly performs the search. Let me know if I can provide more logs or screenshots for these failure modes somehow...

theahura commented 1 month ago

Hmm ok I'll take another look tomorrow. The issue is that it's pretty hard to fix without being able to replicate. Maybe I need to try on windows instead of Ubuntu 🤔

theahura commented 1 month ago

ok i think i might just get rid of the search feature entirely. It's way too buggy, breaks constantly, and it's hard to communicate to users what's going on anyway. So i'm just going to get rid of that part of the tool.

It's a bit of a bummer, because I think it makes this tool much less useful :shrug:

theahura commented 1 month ago

Alright latest version removes everything related to search, and all messages are deleted from both sides now